Add an ESTIA NeXus workflow #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokasimr
reviewed
May 12, 2025
Contributor
jokasimr
left a comment
jokasimr
left a comment
There was a problem hiding this comment.
Looks good to me! Only problem is (as you mentioned) VanadiumRun shows up in the graph. I think we should change that before releasing.
I'm also a bit confused why Position shows up in the graph in the Estia Mcstas example, but not in the Amor example. Why is that?
Member
Author
This was already the case before. There were unused params in the |
jokasimr
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
Note that this is based on #158
This seems to work without any modifications with CODA files. We don't have any good files for tests, so I didn't add any yet. But I am going to add an integration test.